Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty process.platform with __runtime_js_sources #24005

Merged
merged 2 commits into from
May 28, 2024
Merged

fix: empty process.platform with __runtime_js_sources #24005

merged 2 commits into from
May 28, 2024

Conversation

marvinhagemeister
Copy link
Contributor

@marvinhagemeister marvinhagemeister commented May 28, 2024 •
edited
Loading

We use the target property of the snapshot options to derive process.platform and process.arch from. This value had an incorrect format when compiled with __runtime_js_sources enabled. This PR fixes that so that process.platform holds the proper value.

Fixes #23164

@marvinhagemeister marvinhagemeister merged commit 1f913f2 into main May 28, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the runtime_flag_platform branch May 28, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: process.platform is undefined compiled with __runtime_js_sources flag
2 participants
@marvinhagemeister @bartlomieju